-
Notifications
You must be signed in to change notification settings - Fork 90
Add slides on value categories #560
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
ba68c70 to
9904d41
Compare
9904d41 to
fc3ff86
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice explanation. I like it.
On the other hand, we'll have a hard time to squeeze it into the already overloaded schedule of the advanced course. Maybe we'll skip parts ? Or we add officially 15mn to every day so that we are a bit more relaxed ?
anyway, beyond the scope of this MR.
talk/basicconcepts/functions.tex
Outdated
| void fVal(T value); fVal(a); // by value | ||
| void fRef(const T &value); fRef(a); // by reference | ||
| void fPtr(const T *value); fPtr(|{\setlength{\fboxsep}{0pt}\color{gray}\colorbox{yellow}{\textsc{&}}}|a); // by pointer | ||
| void fPtr(const T *value); fPtr(|{\setlength{\fboxsep}{0pt}\color{gray}\colorbox{yellow}{\textsc{\&}}}|a); // by pointer |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
somehow this & now appears on yellow background... no clue why
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It was yellow also in the past. The idea was to give a visual aid because it's the only call that requires using the address-of operator.
If it's not needed, we can remove it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, I found it weird, did not think it could be deliberate, I really thought it was a bug. So yes, I would remove.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, removed now.
243a41e to
02173cb
Compare
Underline why move constructors must be noexcept using the example of a vector that needs to reallocate.
02173cb to
9359ff3
Compare
When colour or other formatting is used in minted with "escapeinside", "&" needs to be escaped depending on the package versions. For one instance, the colour box isn't deemed necessary, any more, so it was removed.
9359ff3 to
c653d29
Compare
noexceptFix #522